search

rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/
Apache License 2.0
15 stars 13 forks source link

Raise on duplicate keys #104

Open jakirkham opened 1 month ago

jakirkham commented 1 month ago

Recently we had an issue in cuCIM where the same key appeared twice ( https://github.com/rapidsai/cucim/pull/757 ). Unfortunately we didn't realize until something didn't behave correctly

It would be helpful to catch these cases in advance by having RDFG raise if it sees duplicate keys

jakirkham commented 1 month ago

cc @grlee77 (who caught this issue)

jameslamb commented 1 month ago

Just ran into another cases of this: https://github.com/rapidsai/rmm/pull/1613#discussion_r1718499266

Alternatively, we could roll out something like yamllint across RAPIDS. It has a rule to prevent duplicate keys: https://yamllint.readthedocs.io/en/stable/rules.html#module-yamllint.rules.key_duplicates

That could probably be used for some of the other things I mentioned in #103 as well.