search

rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/
Apache License 2.0
15 stars 13 forks source link

chore(refactor): update pre-commit hook verions, pyupgrade target Python version #106

Closed jameslamb closed 2 months ago

jameslamb commented 2 months ago

This project supports python>=3.9

https://github.com/rapidsai/dependency-file-generator/blob/4e32ded33b3df70e88cff06bac59488fca74ae7f/pyproject.toml#L21

But is telling pyupgrade it supports python>=3.8.

https://github.com/rapidsai/dependency-file-generator/blob/4e32ded33b3df70e88cff06bac59488fca74ae7f/.pre-commit-config.yaml#L22-L25

This fixes that, and updates all the other hook versions (pre-commit autoupdate) since it's been a while.

Notes for Reviewers

Shouldn't we upgrade the floor to requires-python = >= 3.10?

I don't think so. That's being done across RAPIDS libraries in https://github.com/rapidsai/build-planning/issues/88 right now, but rapids-dependency-file-generator is used in many places outside of RAPIDS (see everything linked to https://github.com/rapidsai/dependency-file-generator/issues/89, for example).

For tools like this, I think we should generally support a wider range of Python versions than RAPIDS itself does.

jameslamb commented 2 months ago

CI here will be fixed by #107

GPUtester commented 2 months ago

:tada: This PR is included in version 1.15.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: