rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/
Apache License 2.0
15 stars 13 forks source link

feat: Add option to delete preexisting files created by dfg each run #32

Closed vyasr closed 1 year ago

vyasr commented 1 year ago

This adds the ability to request that dfg erase any files it previously created before generating new ones. This logic may be used to replace cleanup logic already present in the tests as well as logic currently embedded in the GHA tool currently running dfg. Moving this logic directly into dfg will allow us to use its pre-commit hook as the primary source of truth for how to run it, both locally and in CI.

Contributes to https://github.com/rapidsai/shared-action-workflows/issues/46

vyasr commented 1 year ago

Note: I have intentionally not modified the pre-commit hook to always include the --clean argument. Even if we do end up wanting that behavior for every repo, I think that's better specified in their pre-commit configs rather than hardcoding it here.

ajschmidt8 commented 1 year ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: