search

rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/
Apache License 2.0
15 stars 13 forks source link

feat: Add support for release assets #35

Closed ajschmidt8 closed 1 year ago

ajschmidt8 commented 1 year ago

This PR configures semantic-release/git to commit release assets back to the repository.

This means that anytime a release is triggered, semantic-release will commit the files whose version numbers were updated in ci/update-versions.sh back to the repository.

Since this plugin introduces a third npm package (@semantic-release/git), I opted to create a proper packages.json file to record these dependencies and their versions (as opposed to installing the dependencies manually in the release.yaml workflow). With the addition of this package.json file, I've also added a config file for renovate which will help keep these dependencies up-to-date. We use renovate on other repositories like rapidsai/ci-imgs (e.g. here).

Fixes #15 Fixes #30

ajschmidt8 commented 1 year ago

Damn. Because of the branch protections, semantic-release has to be configured to commit with admin credentials. I will have to set this up to use my creds in a follow-up PR.

See here: https://github.com/semantic-release/git/issues/71

ajschmidt8 commented 1 year ago

:tada: This PR is included in version 1.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ajschmidt8 commented 1 year ago

Okay. Getting closer...

I needed to push the following follow-up commits to get it working:

Here is the commit with the updated versions:

But it seems to have broken the PyPI releases now:

Investigating that now...

ajschmidt8 commented 1 year ago

Okay, final fix is in: https://github.com/rapidsai/dependency-file-generator/commit/175fd74e9b42192bb5e0662c3d3872327f56b44a.

I think everything is working now.