Closed trxcllnt closed 7 months ago
I think these changes are considered breaking because of the new stdout
flag/behavior.
It will break test scripts like this: https://github.com/rapidsai/cudf/blob/72c067726ccfb6e87033d34ab07b4dc79b5e4a3e/ci/test_python_common.sh#L10-L14
@trxcllnt, can you add a BREAKING CHANGE
note to your PR body as mentioned here https://github.com/rapidsai/dependency-file-generator/blob/main/CONTRIBUTING.md? That will make sure the next release increments the major version.
Our CI images pin to the current major version of dfg
: https://github.com/rapidsai/ci-imgs/blob/cac1028880574b466ed37a4aec8aaf93d3eab0b2/Dockerfile#L117-L119
But we'll need a way to incrementally roll this out to each repository before we update the version in our CI images so that we don't break CI for everyone.
I thought about this in the past, but never took any action on it due to time constraints.
I think one way we can fix it is to add a new optional input, install_dfg_version
, to the relevant shared workflows here: https://github.com/rapidsai/shared-action-workflows/tree/branch-23.06/.github/workflows.
install_dfg_version
will be a version specifier for rapids-dependency-file-generator
. When it's set, it will install the specified version. When it is not set, it will simply do nothing.
Then each repo can manually opt-in to the new major version. Once all the repos are using the new version, we can update the CI image version accordingly and then go back and clean up all of the optional install_dfg_version
arguments in each repository.
@trxcllnt apologies for the delay in reviewing this PR. I propose that we we split this up so that the uncontroversial pieces can get merged quickly, if you're open to that.
stdout
to all file types (especially pyproject.toml)@trxcllnt would you like some help finishing this up? Let me know if you want to chat about it or need some extra person-hour help.
@trxcllnt @vyasr Can we get this PR to a completed state? It keeps biting us that we don't have pyproject matrix support. I can help with a review, if that's what is needed, but it seems like there is some code work to be done still.
I'll defer to @trxcllnt here. He had an idea of how best to rewrite the generator to better support this behavior.
Replaced by #74
stdout
for all output types via the new--stdout
flag--file_key
,--output
, or--matrix
(or any combination of the three)--file_key
and--output
argumentsFixes https://github.com/rapidsai/dependency-file-generator/issues/46
Enables the
dependencies.yaml
changes in this branch.Example generating requirements.txt:
Example generating pyproject.toml