rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/
Apache License 2.0
15 stars 13 forks source link

refactor: make configuration-passing from make_dependency_files() to make_dependency_file() stricter #65

Closed jameslamb closed 8 months ago

jameslamb commented 8 months ago

Similar to #64, this proposes small changes to make bugs related to passing configuration between the project's functions less likely.

How is this safe?

make_dependency_file() is only called in one place, and that place supplies a value for extras.

https://github.com/rapidsai/dependency-file-generator/blob/36a40613235089b4de271367ccef3674678c1555/src/rapids_dependency_file_generator/rapids_dependency_file_generator.py#L442-L450

GPUtester commented 6 months ago

:tada: This PR is included in version 1.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: