Closed jameslamb closed 3 months ago
Fixes #85.
Contributes to https://github.com/rapidsai/build-planning/issues/31 (via making debugging those changes easier).
dependency-file-generator
./pyproject.toml
./python/cudf/pyproject.toml
This proposes the following:
make_dependency_files()
conda_dir
pyproject_dir
requirements_dir
get_output_dir()
Installed the version from main on this branch.
main
git checkout main -- src/rapids_dependency_file_generator/_rapids_dependency_file_generator.py pip install --ignore-installed .
Confirmed that this new unit test fails on main, and is reading in the root-level pyproject.toml instead of the nested one.
pyproject.toml
pytest tests/test_rapids_dependency_file_generator.py
Confirmed that it fails with the same error as #85 on the new test project added here.
cd ./tests/examples/nested-pyproject rapids-dependency-file-generator \ --output pyproject \ --file-key sparkly_unicorn \ --matrix "cuda=100.1" # tomlkit.exceptions.NonExistentKey: 'Key "project" does not exist.'
Tested on cudf's actual dependencies.yaml on branch-24.06.
cudf
dependencies.yaml
branch-24.06
rapids-dependency-file-generator \ --output pyproject \ --file-key py_run_cudf \ --matrix "cuda=12.2"
:tada: This PR is included in version 1.13.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Fixes #85.
Contributes to https://github.com/rapidsai/build-planning/issues/31 (via making debugging those changes easier).
85 contains a reproducible example and details of the problem this solves. In short:
dependency-file-generator
currently defaults to looking for the file to overwrite in the current working directory./pyproject.toml
as the source for an invocation that should be handling e.g../python/cudf/pyproject.toml
This proposes the following:
make_dependency_files()
to alwaysconda_dir
/pyproject_dir
/requirements_dir
as a source of the file to load / possibly overwriteget_output_dir()
docstringget_output_dir()
to use keyword-only argumentsNotes for Reviewers
How I tested this
Installed the version from
main
on this branch.Confirmed that this new unit test fails on
main
, and is reading in the root-levelpyproject.toml
instead of the nested one.Confirmed that it fails with the same error as #85 on the new test project added here.
Tested on
cudf
's actualdependencies.yaml
onbranch-24.06
.