search

rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/
Apache License 2.0
15 stars 13 forks source link

chore(refactor): require keyword-only args in make_dependency_files() #88

Closed jameslamb closed 6 months ago

jameslamb commented 6 months ago

Contributes to https://github.com/rapidsai/build-planning/issues/31.

Follow-up to https://github.com/rapidsai/rapids-build-backend/pull/17#discussion_r1576662655.

Proposes restricting make_dependency_files() to only accepting keyword arguments, to reduce the risk of oops-passed-this-in-the-wrong-order types of bugs, and to make code using it a little bit easier to read.

Notes for Reviewers

The only direct usage of that function outside of this project itself is in rapids-build-backend, and that's already using keyword arguments in its one call (GitHub search | rapids-build-backend code link).

So this is safe to merge and shouldn't break anything.

jameslamb commented 6 months ago

thanks @KyleFromNVIDIA !

GPUtester commented 6 months ago

:tada: This PR is included in version 1.13.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: