Remove "--file_key" and "--prepend_channels" - Githubissues

rapidsai / dependency-file-generator

https://pypi.org/project/rapids-dependency-file-generator/

Apache License 2.0

15 stars 13 forks source link

Remove "--file_key" and "--prepend_channels" #89

Closed jameslamb closed 3 months ago

jameslamb commented 5 months ago

Description

In #71, the arguments --file_key and --prepend-channels were deprecated.

Uses of them across RAPIDS should be removed, and then they and the corresponding deprecation warnings here should be removed.

Benefits of this work

simplifies rapids-dependency-file-generator
removes a source of noise in CI logs across RAPIDS projects

Acceptance Criteria

0 non-archived projects in the rapidsai org use --file_key or --prepend-channels in their calls to rapids-dependency-file-generator
arguments --file_key and --prepend-channels do not exist in rapids-dependency-file-generator

Approach

Across the rapidsai GitHub org:

replace --file_key with --file-key (note the -)
replace --prepend-channels with one or more --prepend-channel

For example this:

rapids-dependency-file-generator \
  --output conda \
  --file_key test_cpp \
  --matrix "cuda=12.2" \
  --prepend-channels "${CPP_CHANNEL};pytorch"

Should become this:

rapids-dependency-file-generator \
  --output conda \
  --file-key test_cpp \
  --matrix "cuda=12.2" \
  --prepend-channel "${CPP_CHANNEL}" \
  --prepend-channel "pytorch"

Notes

N/A

GPUtester commented 3 months ago

:tada: This issue has been resolved in version 1.14.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: