Closed jameslamb closed 3 months ago
Sure, I'll start making them a bit bigger. Was trying to keep them small and focused so they'd be easier to review but I might not have found the right balance there.
After this + #94 are merged I think this typing work could be finished in just 1 or maybe 2 more PRs.
:tada: This PR is included in version 1.13.9 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Contributes to #87
Resolves these errors from
mypy
:os.PathLike
is not intended to be used as a generic type hint wherever you might have a string that represents a filepath. It has a different, very specific purpose. From https://docs.python.org/3/library/os.html#os.PathLikedelete_existing_files()
is always passed a Python string, so it's type hint should bestr
.https://github.com/rapidsai/dependency-file-generator/blob/6b0247a23556bf4cc5f5093864cfafd3edb1c363/src/rapids_dependency_file_generator/_cli.py#L24-L34
https://github.com/rapidsai/dependency-file-generator/blob/6b0247a23556bf4cc5f5093864cfafd3edb1c363/src/rapids_dependency_file_generator/_cli.py#L117-L118
https://github.com/rapidsai/dependency-file-generator/blob/6b0247a23556bf4cc5f5093864cfafd3edb1c363/src/rapids_dependency_file_generator/_cli.py#L148-L149
How I tested this