fix: raise an informative error if pip map is passed for requirements file

jameslamb commented 5 months ago

Fixes #87.

fixes the remaining issues raised by mypy (without --strict)
adds a pre-commit check running mypy
updates all the other pre-commit checks to their latest versions
- it's been a while, figured I'd do that since I'm touching this file anyway
- via pre-commit autoupdate

Notes for Reviewers

This won't pass CI until #94 is merged.

jameslamb commented 5 months ago

The extra couple commits I just pushed here were attempts to diagnose this:

An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/python', '-mvirtualenv', '/home/runner/.cache/pre-commit/repooxbc06io/py_env-python3.9', '-p', 'python3.9')
return code: 1
stdout:
    RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.9'
stderr: (none)
Check the log at /home/runner/.cache/pre-commit/pre-commit.log

(build link).

I had been using the following in .pre-commit-config.yaml:

default_language_version:
    python: python3.9

Changing that to this pattern used across most of the RAPIDS repos resolved it:

default_language_version:
    python: python3

I'm going to merge this as I don't think that's a controversial choice and it'd be easy to revert. Wanted to just explain so you know I'm not trying to sneak in some other changes on a stale approval 😅

GPUtester commented 5 months ago

:tada: This PR is included in version 1.13.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

rapidsai / dependency-file-generator

fix: raise an informative error if pip map is passed for requirements file #97

Notes for Reviewers