Closed henryiii closed 6 months ago
Thanks for pointing this out @henryiii! We're largely tracking all of the same suggestions on a RAPIDS-wide basis in https://github.com/rapidsai/build-planning/issues/58 (and in my first comment response in that issue) Could you take a look and see if there's anything you would change in that issue? From a quick look, it also captures the same things (minimum-version->version, (probably) remove cmake/ninja from reqs).
I was looking at the config, and saw some updates, but didn't know where to make them. For configs like this:
The
cmake
andninja
items should be removed. The"scikit_build_core.build"
adds them intelligently based on what's already on the system and what you set intool.scikit-build
.If you increase the
scikit-build-core
version here to>=0.9
, you can drop the[pyproject]
extra, it's included now.And, for that section:
I'd recommend setting the
minimum-version
to0.9
, changingcmake.minimum-version = "3.26.4"
tocmake.version = ">=3.26.4"
(theminimum-version
value will enforce this if set high enough). This also protects the defaults, in case you want to remove a few of the defaults. The minimum would be, then: