reorganize ruff settings

rapidsai / deployment

RAPIDS Deployment Documentation

https://docs.rapids.ai/deployment/stable/

9 stars 28 forks source link

reorganize ruff settings #363

Closed jameslamb closed 5 months ago

jameslamb commented 5 months ago

Contributes to #333 .

ruff is currently raising this warning:

warning: The top-level linter settings are deprecated in favour of their counterparts in the `lint` section. Please update the following options in `pyproject.toml`:
  - 'select' -> 'lint.select'

This proposes the following:

moving ruff configuration into the new, not-deprecated tables in pyproject.toml
adding comments to the list of checks in select indicating which groups of rules they refer to (ruff rules docs)

jameslamb commented 5 months ago

Converting this to draft. I think if we give it a bit of time for the conda cache used in these CI jobs to expire, they'll pull in the new, fixed Sphinx package and work again (https://github.com/conda-forge/sphinx-feedstock/pull/160).

I'll check back on this tomorrow.

jameslamb commented 5 months ago

Alright, some progress! Re-rerunning the failed jobs, looks like the CI job here in GitHub actions succeeded.

https://github.com/rapidsai/deployment/actions/runs/8728166096/job/23980561971?pr=363

So the new sphinx package must be getting pulled in there.

But the job out on readthedocs still failed, with the same error. Will try again in a bit.

jameslamb commented 5 months ago

Looks like conda repodata in all the places that this CI runs have been updated to pull in the new sphinx package, and now this is passing 🎉

This is ready for review.