Closed jameslamb closed 3 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Converting this to draft. I think if we give it a bit of time for the conda
cache used in these CI jobs to expire, they'll pull in the new, fixed Sphinx package and work again (https://github.com/conda-forge/sphinx-feedstock/pull/160).
I'll check back on this tomorrow.
Alright looks like the issue with the sphinx
conda-forge package has been resolved, and the builds here are passing 🎉
This is ready for review.
Contributes to #333.
Fixes these issues in
rapids-sagemaker-hpo/notebook.ipynb
found byruff
:I agree with
ruff
here... I think it'd be clearer to not have the star imports. And doing that also improves the likelihood of linters being able to catch issues in the way those functions being imported likefrom helper_functions import *
are called.