search

rapidsai / deployment

RAPIDS Deployment Documentation
https://docs.rapids.ai/deployment/stable/
9 stars 28 forks source link

WIP: install tomli in docs environment #365

Closed jameslamb closed 5 months ago

jameslamb commented 5 months ago

Over in #363, I see the Build and Deploy CI job failing like this:

Running Sphinx v7.3.5

Extension error:
Could not import extension sphinx.builders.changes (exception: No module named 'tomli')
make: *** [Makefile:20: dirhtml] Error 2
Error: Process completed with exit code 2.

Looks like we're getting a version of sphinx that doesn't declare its dependency on tomli.

That was just added 16 hours ago, in v7.3.5: https://github.com/sphinx-doc/sphinx/commit/8a944ac87c1fb443ab4b9d08bae3a9318d164bbf.

But the didn't make it into the conda-forge recipe: https://github.com/conda-forge/sphinx-feedstock/blob/512d4800c1d3e054ac23724dcab3fe620be3f0eb/recipe/meta.yaml#L21

This proposes explicitly adding tomli to the conda env here to unblock CI.

Notes for Reviewers

I'll go put up a PR on the conda-forge recipe for sphinx to add that dependency on tomli, but we don't need to wait for that here.

jameslamb commented 5 months ago

I just put up https://github.com/conda-forge/sphinx-feedstock/pull/160. If that's merged soon enough, we could probably just close this PR.

But leaving this here so we have an option to merge and unblock CI without having to wait on that conda-forge change.

jameslamb commented 5 months ago

https://github.com/conda-forge/sphinx-feedstock/pull/160 was approved and merged really quickly, so we don't need this PR any more 😁