search

rapidsai / deployment

RAPIDS Deployment Documentation
https://docs.rapids.ai/deployment/stable/
9 stars 27 forks source link

fix unused-import warnings in xgboost-dask-databricks #366

Closed jameslamb closed 3 months ago

jameslamb commented 3 months ago

Contributes to #333.

Fixes the following warnings from the source/examples/xgboost-data-databricks notebook.

F401 [*] `time.time` imported but unused
F401 [*] `pandas` imported but unused
F401 [*] `cupy` imported but unused
F401 [*] `cudf` imported but unused
F401 [*] `dask` imported but unused
F401 [*] `dask.dataframe` imported but unused
E501 Line too long (128 > 120)
F821 Undefined name `spark`
F821 Undefined name `spark`
F821 Undefined name `spark`

How I tested this

Searched through the notebook to double-check that there wasn't any commented-out code that would rely on these.

Ran pre-commit with ruff configured to look at notebooks, to confirm these changes fixed those warnings (as described in https://github.com/rapidsai/deployment/issues/333#issuecomment-2066720309).

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB