rapidsai / deployment

RAPIDS Deployment Documentation
https://docs.rapids.ai/deployment/stable/
9 stars 28 forks source link

fix some SageMaker examples #381

Closed jameslamb closed 4 months ago

jameslamb commented 4 months ago

Contributes to #374.

Fixes the following:

Improves the following, but not sure if it is totally working:

The higgs notebook in particular was badly broken... in ways that make me suspect it's been in a bad state for a few releases.

Notes for Reviewers

There are a LOT of changes here, I've tried to add inline comments explaining all of them.

How does this "improve" but not "fix" the rapids-sagemaker-hpo notebook?

I wasn't able to run it to completion because the AWS account I was in had service quotas limiting me to 1 ml.p3.2xlarge or ml.p3.8xlarge instance, and that notebook needs at least 2.

References

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jameslamb commented 4 months ago

From our conversation earlier today... I think this is ready to merge @jacobtomlinson