search

rapidsai / devcontainers

18 stars 28 forks source link

Upgrade CCCL clang-format to version 18 #343

Closed bernhardmgruber closed 4 months ago

bernhardmgruber commented 4 months ago

Fixes: #341

copy-pr-bot[bot] commented 4 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

trxcllnt commented 4 months ago

/ok to test

trxcllnt commented 4 months ago

@bernhardmgruber This looks good to me. Once we merge this and publish new containers, clang-format-18 could potentially produce different formatting than 17 for users. Does merging this need to be sync'd with a PR that updates/re-formats CCCL sources?

bernhardmgruber commented 4 months ago

@trxcllnt yes, it needs to be synced with this PR in CCCL: https://github.com/NVIDIA/cccl/pull/1928. I can take care of this once you merge.

trxcllnt commented 4 months ago

Ok, I'll merge this now and new images should be published shortly after.