rapidsai / devcontainers

18 stars 26 forks source link

ninja bash completion is missing #362

Closed bernhardmgruber closed 2 months ago

bernhardmgruber commented 2 months ago

I noticed that despite ninja being available in /usr/bin/ninja, the apt package ninja-build is not installed. This package would include the bash completion for ninja, which is available by sourcing /usr/share/bash-completion/completions/ninja.

Since bash completion is super useful, I kindly ask to either provide the completion file in the dev containers or install the apt package by default.

trxcllnt commented 2 months ago

The devcontainers install ninja from the github releases, but we could definitely add the ninja bash completions too.

bernhardmgruber commented 2 months ago

This would be amazing! You could even source it upon startup for maximum user satisfaction :)

trxcllnt commented 2 months ago

Placing it into the bash completions dir will source it automatically.

bernhardmgruber commented 2 months ago

Thx a lot! <3