search

rapidsai / devcontainers

18 stars 28 forks source link

Add llvm-tools to all CCCL devcontainers #386

Closed wmaxey closed 2 months ago

wmaxey commented 2 months ago

This allows using FileCheck, hopefully from LLVM-18, in all devcontainers.

This fixes some inconsistency with how FileCheck parses nested [[[]]].

copy-pr-bot[bot] commented 2 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

trxcllnt commented 2 months ago

/ok to test

wmaxey commented 2 months ago

I believe @trxcllnt is a better reviewer here. The only issue I'd mention is to consider how much size this adds to the image.

Uhhhh, yeah that's a good point... How large is the tools package?