rapidsai / devcontainers

18 stars 28 forks source link

Remove nx-cugraph from cugraph #418

Closed eriknw closed 1 week ago

eriknw commented 1 week ago

I believe this is needed to remove nx-cugraph from the cugraph repo being done in https://github.com/rapidsai/cugraph/pull/4756

This is a subset of the changes @jameslamb is making in https://github.com/rapidsai/devcontainers/pull/417. Does it make sense to do this change for nx-cugraph and cugraph-gnn independently (how close is cugraph-gnn to being removed?)? Should we also add nx-cugraph as done in that PR? Anything else?

@nv-rliu @jameslamb @rlratzel

jameslamb commented 1 week ago

Also note that the CI failures here weren't because of your changes, and should resolve on a re-run now that https://github.com/rapidsai/raft/pull/2490 was merged.

eriknw commented 1 week ago

Thanks @jameslamb I suspected we needed to make those changes, thanks for explaining :) . Updated.

trxcllnt commented 1 week ago

@jameslamb Even if we don't add devcontainer CI / devcontainer configs in the nx-cugraph repo

We should add devcontainers to the new nx-cugraph repo. Aside from them being a convenient way to work on a project for outside contributors, they also help ensure nx-cugraph changes don't break devcontainer and DLFW builds.

jameslamb commented 1 week ago

We should add devcontainers to the new nx-cugraph repo

Great, let's do that. Want to put up a PR at https://github.com/rapidsai/nx-cugraph?

jameslamb commented 1 week ago

Believe CI errors like this:

/home/coder/cuvs/cpp/src/neighbors/iface/iface.hpp(176): error: incomplete type is not allowed

1 error detected in the compilation of "/home/coder/cuvs/cpp/src/neighbors/iface/iface_cagra_float_uint32_t.cu".

(build link)

Should be fixed by https://github.com/rapidsai/cuvs/pull/467

jameslamb commented 1 week ago

I put up a PR to add devcontainers CI jobs for nx-cugraph: https://github.com/rapidsai/nx-cugraph/pull/25

jameslamb commented 1 week ago

Even though this change is also covered in #417, CI just started over there and takes a couple hours to run.

Merging this to unblock https://github.com/rapidsai/cugraph/pull/4756 and https://github.com/rapidsai/nx-cugraph/pull/25