rapidsai / docs

RAPIDS Documentation Site
https://docs.rapids.ai
36 stars 49 forks source link

Fix ucxx versioning #503

Closed AyodeAwe closed 5 months ago

AyodeAwe commented 5 months ago

This PR addresses the versioning discrepancy in the documentation of the ucxx library. Previously, we used the RAPIDS versioning convention for ucxx in our docs workflow and overwrote the RAPIDS versioning with ucxx's actual versioning during the deploy step. This PR updates the workflow to use the correct ucxx version number directly in our docs deployment workflow.

Before this PR is merged, this PR should be merged - the PR updates the build step in build_docs.sh to use the correct version numbers when uploading docs to s3.

Before both these PRs are merged, we should rename/re-sync the relevant directories up in s3 from the RAPIDS versioning used to ucxx's.

Testing: Changes in download_from_s3.sh were tested by running the download_lib_docs function locally. Other processing scripts were tested locally by downloading rmm and libucxx (legacy, stable, nightly) docs and running ci/post_process.sh. Outputs were as expected.

netlify[bot] commented 5 months ago

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
Latest commit 721f1a24a04cd2596c97ee25be948975fc64a2bd
Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/660197d16a57cf000811a023
Deploy Preview https://deploy-preview-503--docs-rapids-ai.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ajschmidt8 commented 5 months ago

After both these PRs are merged, we should rename/re-sync the relevant directories up in s3 from the RAPIDS versioning used to ucxx's.

The directories should be renamed before this PR is merged. Otherwise the build on the default branch will not complete successfully since the old docs are still named incorrectly