search

rapidsai / jupyterlab-nvdashboard

A JupyterLab extension for displaying dashboards of GPU usage.
BSD 3-Clause "New" or "Revised" License
598 stars 78 forks source link

Remove install of jupyterlab_nvdashboard.json #145

Closed cmd-ntrf closed 1 year ago

cmd-ntrf commented 1 year ago

jupyterlab-nvdashboard does not provide a jupyter server extension. The loading of the extension is managed by jupyter-server-proxy, hence there is no need to install jupyterlab_nvdashboard.json.

Furthermore, Jupyter server requires extensions to define a _load_jupyter_server_extension function. https://jupyter-server.readthedocs.io/en/latest/developers/extensions.html

When the function is not defined, but the JSON file is installed, it triggers an non-fatal exception when loading JupyterLab.

GPUtester commented 1 year ago

Can one of the admins verify this patch?

Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.

jacobtomlinson commented 1 year ago

ok to test