search

rapidsai / jupyterlab-nvdashboard

A JupyterLab extension for displaying dashboards of GPU usage.
BSD 3-Clause "New" or "Revised" License
588 stars 77 forks source link

Harmonize the icon color with the standard color #201

Open krassowski opened 2 months ago

krassowski commented 2 months ago

Changes the expansion-card.svg code from jp-icon0 class to jp-icon3 which is more appropriate for sidebar/window icons in JupyterLab design style.

Fixes https://github.com/rapidsai/jupyterlab-nvdashboard/issues/199

Light theme

Before After
image image

Dark theme

Before After
image image

High contrast dark theme

Before After
image image
copy-pr-bot[bot] commented 2 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

AjayThorve commented 2 months ago

/ok to test

krassowski commented 1 month ago

:tada:

jacobtomlinson commented 2 weeks ago

@rapidsai/ops I'm a little unsure what is expected here in CI, could someone take a look?

AyodeAwe commented 2 weeks ago

@jacobtomlinson

branch-24.02 for the shared-workflows is still being referenced in pr.yaml and build.yaml. These should be updated to branch-24.10.

Examples:

AjayThorve commented 2 weeks ago

@AyodeAwe thanks! I have created a PR to fix the issue you pointed: https://github.com/rapidsai/jupyterlab-nvdashboard/pull/204

cc @jacobtomlinson

AyodeAwe commented 2 weeks ago

@AjayThorve I had thought we could simply include the needed changes in this PR but seeing that we've created a dedicated PR for it, we should get that PR merged asap, after which we should pull in the changes into this PR.

AjayThorve commented 2 weeks ago

/ok to test