search

rapidsai / legate-boost

GBM implementation on Legate
https://rapidsai.github.io/legate-boost/
Apache License 2.0
8 stars 6 forks source link

docs link is broken #134

Closed jameslamb closed 1 month ago

jameslamb commented 1 month ago

The README links to https://rapidsai.github.io/legate-boost/, but that URl is 404-ing.

image

I suspect I broke that with the changes in #125 😬 . I'll look into it.

jameslamb commented 1 month ago

I wonder if maybe something else is going on with the settings? Because even just going to https://rapidsai.github.io/, I see "There isn't a GitHub Pages site here.".

image

I've put up an ops request requesting admin access so I can see the settings here.

jameslamb commented 1 month ago

Noting that adding /html to the path, I can see the docs.

Broken: https://rapidsai.github.io/legate-boost/ Works: https://rapidsai.github.io/legate-boost/html/

Even more evidence that @raydouglass 's theory is right and that we just need one more level of nesting in the artifact reference (implemented in #136).

jameslamb commented 1 month ago

Looks like #136 fixed this!

Build link: https://github.com/rapidsai/legate-boost/actions/runs/10221446440/job/28284013683

docs link: https://rapidsai.github.io/legate-boost/

image