rapidsai / legate-boost

GBM implementation on Legate
https://rapidsai.github.io/legate-boost/
Apache License 2.0
8 stars 8 forks source link

update some CI versions, move docs-building to a script #146

Closed jameslamb closed 2 months ago

jameslamb commented 2 months ago

Contributes to #115

This PR has some miscellaneous small CI things that I noticed while working on adding conda builds in #129. Pulling them into a separate PR to make the diff for that PR smaller.

Notes for Reviewers

See comments on the diff for reasoning behind other specific changes.

jameslamb commented 2 months ago

I'm still not quite sold on the idea of pre-commit hook, feels like an elaborate effort to have yet another dependency manager for a simple task

Thanks for this. I felt this way for a long time... working on RAPIDS is the first time I've ever really used pre-commit.

Since I've gotten used to it on RAPIDS repos, I've found it convenient and powerful, relative to every repo having its own slightly different shell scripts or Makefile targets.

For what it's worth, I don't actually use the git functionality at all... I never pre-commit install to make it run as a git hook. I just use this tool to run all static analysis and autoformatting over all files, like pre-commit run --all-files.