rapidsai / miniforge-cuda

https://hub.docker.com/r/rapidsai/miniforge-cuda/
12 stars 9 forks source link

make build-arg passing stricter #57

Closed jameslamb closed 8 months ago

jameslamb commented 8 months ago

Contributes to https://github.com/rapidsai/build-planning/issues/7.

See https://github.com/rapidsai/ci-imgs/pull/102 for a description of why I'm proposing this.

In short, I think it's desirable for builds to fail with a big loud error if the expected build args aren't passed through.

e.g. this:

docker-buildx build \
    -f ./Dockerfile \
    -t rapidsai/miniforge-cuda:local \
    .

Should result in

ERROR: failed to solve: nvidia/cuda:notset-base-notset: docker.io/nvidia/cuda:notset-base-notset: not found