Refactor cast to use Visitor pattern

rapidsai / node

GPU-accelerated data science and visualization in node

https://rapidsai.github.io/node/

Apache License 2.0

187 stars 20 forks source link

Refactor cast to use Visitor pattern #273

Closed bryevdv closed 3 years ago

bryevdv commented 3 years ago

closes #262

Still needs a little work:

[x] add new string-to-numeric casts (with tests)
[x] add missing cast tests for timestamps

as well as any other casts that I have missed that come up in review

bryevdv commented 3 years ago

@trxcllnt I think this is more or less ready however I would describe the timestamp tests as "plausible but suspect" so attention there is appreciated

Edit: actually I forgot I left in the TimestampDay block, those test results actually don't make sense to me (e.g. why would a day resolution timestamp preserve microseconds?) tho looking at timestamp.ts all the implementations seem to be identical?