search

rapidsai / node

GPU-accelerated data science and visualization in node
https://rapidsai.github.io/node/
Apache License 2.0
187 stars 20 forks source link

[Review] cuml refine implementation + umap demo #293

Closed AjayThorve closed 3 years ago

AjayThorve commented 3 years ago

WIP PR to implement the refine(iterative fitting) and a graph demo showcasing the same.

Currently cuml build pull from my private fork on top of version 21.10 -> https://github.com/AjayThorve/cuml/tree/fea/umap-refine-21.10

Allows us to visualize step-wise training, without needing callbacks umap-refine

trxcllnt commented 3 years ago

@AjayThorve have we started discussing getting these changes merged into cuML? Would be good to get those in there, then update our RAPIDS dependencies to 21.10.

AjayThorve commented 3 years ago

@AjayThorve have we started discussing getting these changes merged into cuML? Would be good to get those in there, then update our RAPIDS dependencies to 21.10.

Not yet I think. But its a good idea to get started on the PR before its too late to merge into 21.10. I'll write unit tests for the ML::UMAP::refine function, and then create a PR on the cuml repo asap.

@trxcllnt here are the changes in the cuml repo, let me know if you have any pre-PR suggestions :sweat_smile:

AjayThorve commented 3 years ago

I think this PR is good to merge, pending CI builds. @trxcllnt, let me know when it's okay to merge this :-)