rapidsai / node

GPU-accelerated data science and visualization in node
https://rapidsai.github.io/node/
Apache License 2.0
187 stars 20 forks source link

`df.join` should accept singleton arguments, not just iterable. #426

Open thomcom opened 2 years ago

thomcom commented 2 years ago

join uses forEach to join across the on: keys. A common use case of join is with a single join column, so we should accept the use of a single join argument.

keys_df.join({other: target_df, on: 'keys', how: 'inner'});

vs

keys_df.join({other: target_df, on: ['keys'], how: 'inner'});