search

rapidsai / pynvjitlink

Apache License 2.0
4 stars 15 forks source link

Try pinning scikit-build-core 0.8.2 #75

Closed gmarkall closed 6 months ago

gmarkall commented 6 months ago

Attempting to ensure that wheels receive the correct platform tags, i.e. manylinux_2_17 and manylinux_2_28 instead of linux_x86-64 and linux_aarch64 that the 0.2.2 wheels seemed to get.

gmarkall commented 6 months ago

Wheels built by this PR appear to be named:

pynvjitlink_cu12-0.2.2-cp310-cp310-manylinux_2_17_x86_64.whl
pynvjitlink_cu12-0.2.2-cp310-cp310-manylinux_2_28_aarch64.whl
pynvjitlink_cu12-0.2.2-cp311-cp311-manylinux_2_17_x86_64.whl
pynvjitlink_cu12-0.2.2-cp311-cp311-manylinux_2_28_aarch64.whl
pynvjitlink_cu12-0.2.2-cp39-cp39-manylinux_2_17_x86_64.whl
pynvjitlink_cu12-0.2.2-cp39-cp39-manylinux_2_28_aarch64.whl

Does this mean that using scikit-build-core 0.8.2 resolved the issue? @raydouglass

raydouglass commented 6 months ago

Does this mean that using scikit-build-core 0.8.2 resolved the issue?

These wheels' platform tags look correct.

gmarkall commented 6 months ago

Turns out we're not running auditwheel, and the correct fix may be to do that instead.

vyasr commented 6 months ago

Closing in favor of #76