rapidsai / raft

RAFT contains fundamental widely-used algorithms and primitives for machine learning and information retrieval. The algorithms are CUDA-accelerated and form building blocks for more easily writing high performance applications.
https://docs.rapids.ai/api/raft/stable/
Apache License 2.0
747 stars 189 forks source link

[REVIEW] Fix VERSION FileNotFoundError in raft-ann-bench #2290

Closed jiangyinzuo closed 4 months ago

jiangyinzuo commented 5 months ago

2285 forgets to include VERSION file, causing _version.py not find VERSION file.

copy-pr-bot[bot] commented 5 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

jiangyinzuo commented 5 months ago

The following python packaging document tells us to add a MANIFEST.in file. https://packaging.python.org/en/latest/guides/single-sourcing-package-version/#single-sourcing-the-package-version

image

Before this commit, python3 -m raft-ann-bench.run will report the following error

Traceback (most recent call last):
  File "<frozen runpy>", line 189, in _run_module_as_main
  File "<frozen runpy>", line 112, in _get_module_details
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/site-packages/raft-ann-bench/__init__.py", line 16, in <module>
    from ._version import __git_commit__, __version__
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/site-packages/raft-ann-bench/_version.py", line 22, in <module>
    .read_text()
     ^^^^^^^^^^^
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/pathlib.py", line 1058, in read_text
    with self.open(mode='r', encoding=encoding, errors=errors) as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/pathlib.py", line 1044, in open
    return io.open(self, mode, buffering, encoding, errors, newline)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: '/home/jiangyinzuo/micromamba/envs/rapids_raft/lib/python3.11/site-packages/raft-ann-bench/VERSION'
jiangyinzuo commented 4 months ago

Solved in https://github.com/rapidsai/raft/pull/2299