search

rapidsai / raft

RAFT contains fundamental widely-used algorithms and primitives for machine learning and information retrieval. The algorithms are CUDA-accelerated and form building blocks for more easily writing high performance applications.
https://docs.rapids.ai/api/raft/stable/
Apache License 2.0
747 stars 189 forks source link

Make thrust nosync execution policy the default thrust policy #2302

Closed abc99lr closed 4 months ago

abc99lr commented 4 months ago

Testing. Do not merge.

Based on the discussions from https://github.com/rapidsai/raft/pull/2293, it's a good idea to test if we could use nosync thrust calls by default. This PR changes the current rmm::exec_policy to its async version rmm::exec_policy_nosync.

copy-pr-bot[bot] commented 4 months ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

abc99lr commented 4 months ago

Tagging @cjnolet to enable testing

cjnolet commented 4 months ago

@abc99lr for future reference, you should be in the rapids org and the raft-triage group. The reason CI isn't automatically starting on this PR is because you haven't signed your commits. This is something you should be able to set up once and it'll "just work" on your dev system going forward. Here's the instructions to do this.

cjnolet commented 4 months ago

/ok to test

abc99lr commented 4 months ago

It seems this PR fails pr / conda-cpp-tests / tests (amd64, 3.11, 12.2.2, ubuntu22.04, v100, latest) (push). But I checked the log and all the status show success. Should we rerun the CI? Or maybe I missed something?

Here is the link to the log. https://github.com/rapidsai/raft/actions/runs/9024355165/job/24800696954?pr=2302

cjnolet commented 4 months ago

@abc99lr yeah it's weird indeed. i"m rerunnig that test checker. It's possible it could have been a chance occurrence.

cjnolet commented 4 months ago

/merge