Use default init in reduction

rapidsai / raft

RAFT contains fundamental widely-used algorithms and primitives for machine learning and information retrieval. The algorithms are CUDA-accelerated and form building blocks for more easily writing high performance applications.

https://docs.rapids.ai/api/raft/stable/

Apache License 2.0

680 stars 180 forks source link

Use default init in reduction #2351

Closed akifcorduk closed 1 month ago

akifcorduk commented 1 month ago

During reduction in device code (reduction.cuh), the value assigned in the residual threads during last stage are zero initilized. However, if we want to reduce some custom type, it might not have the appropriate constructor. Thus, this PR makes the change so that we call the default constructor for the residual values.

copy-pr-bot[bot] commented 1 month ago

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

dantegd commented 1 month ago

/ok to test

akifcorduk commented 1 month ago

/merge

tfeher commented 1 month ago

/merge