search

rapidsai / raft

RAFT contains fundamental widely-used algorithms and primitives for machine learning and information retrieval. The algorithms are CUDA-accelerated and form building blocks for more easily writing high performance applications.
https://docs.rapids.ai/api/raft/stable/
Apache License 2.0
784 stars 195 forks source link

2412 remove libraft vss instantiations #2498

Closed cjnolet closed 1 week ago

cjnolet commented 1 week ago

We are keeping random ball cover headers in RAFT for 24.12, and random ball cover depends on distances and brute-force. Because of this, we're going to leave all of the VSS headers in RAFT for the time being, and will remove them all in a future PR once RBC is formally migrated to cuVS. The tests, benchmarks, and instantiations for all of these APIs will be removed, though, so while the actual headers can still be used, they are no longer being tested and could fail without warning.

I've also included a note to users in the README about this, stating to use at their own risk.

review-notebook-app[bot] commented 1 week ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

cjnolet commented 1 week ago
  1. Looks like that file was brought back, likely as a result of a bad merge. We can remove it in a follow on.
  2. This is okay. We do still have some instantiations and the important headers are no longer using it.
  3. This is okay. I'm not removing the headers in this PR, so these will be left around. Users have been warned about this for some time, so they'll need to supply their own hnswlib if they still want to use those headers.
cjnolet commented 1 week ago

/merge

bdice commented 1 week ago

Do we want to delete cpp/template/cmake/thirdparty/get_raft.cmake? It is the only file left in cpp/template/*. If we do remove it, we also need to clean up a reference in ci/release/update-version.sh.

Looks like that file was brought back, likely as a result of a bad merge. We can remove it in a follow on.

I filed https://github.com/rapidsai/raft/pull/2500 to address this.