rapidsai / raft

RAFT contains fundamental widely-used algorithms and primitives for machine learning and information retrieval. The algorithms are CUDA-accelerated and form building blocks for more easily writing high performance applications.
https://docs.rapids.ai/api/raft/stable/
Apache License 2.0
766 stars 194 forks source link

[FEA] Integrate balanced KMeans #700

Open tfeher opened 2 years ago

tfeher commented 2 years ago

The approximate nearest neighbors algorithms (IVF-Flat #652, IVF-PQ) use a balanced k-means implementation. In #652, balanced kmeans is separate implementation from #605. These two implementations should be merged to avoid code duplications.

One should ensure that the changes are benchmarked, not to loose performance for the approximate nearest neighbors methods.

Tasks

About reducing the duplication of primitive functions, the following issues came up earlier:

github-actions[bot] commented 2 years ago

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

Nyrio commented 2 years ago

move k-means benchmarks from cuML

Can be marked as done.

tfeher commented 2 years ago

Could you open a PR to remove https://github.com/rapidsai/cuml/blob/branch-22.12/cpp/bench/sg/kmeans.cu?

Nyrio commented 2 years ago

@tfeher Perhaps that should wait until we've merged https://github.com/rapidsai/cuml/pull/4713 that replaces the cuML implementation with the raft implementation?