Open zbjornson opened 3 years ago
This issue has been marked rotten due to no recent activity in the past 90d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.
This issue has been marked stale due to no recent activity in the past 30d. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be marked rotten if there is no activity in the next 60d.
Describe the bug
The
raft::handle_t
destructor callsdestroy_resources()
, which can throw a variety of exceptions. It's hard/impossible to catch those if stack unwinding is in progress. I see a TODO to useNO_THROW
and enable logging, but personally I don't like to see log messages about failed dtors due to a previous error.https://github.com/rapidsai/raft/blob/d1e04a85eb701265b1d757db00eb6de4c488438d/cpp/include/raft/handle.hpp#L222-L223
Is it necessary to check the destroy calls at all?
Example code that terminates
```cpp inline void transpose(raft::handle_t& handle, float* out, float* in, size_t n_rows, size_t n_cols) { const float alpha = 1.0f; const float beta = 0.0f; const int lda = n_rows; const int ldb = n_cols; const int ldc = lda; DeviceBuffer