search

rapidsai / raft

RAFT contains fundamental widely-used algorithms and primitives for machine learning and information retrieval. The algorithms are CUDA-accelerated and form building blocks for more easily writing high performance applications.
https://docs.rapids.ai/api/raft/stable/
Apache License 2.0
755 stars 192 forks source link

[FEA] catch missing includes #840

Open MatthiasKohl opened 2 years ago

MatthiasKohl commented 2 years ago

Is your feature request related to a problem? Please describe. I just ran into an issue where a RAFT header simply had a missing include: https://github.com/rapidsai/raft/pull/839

Describe the solution you'd like This kind of issue could be caught fairly easily by an automated script that just creates empty CUDA files, then includes every public header from RAFT and tries to compile.

Describe alternatives you've considered

Additional context Such an automated script could be run in CI if it doesn't take too long. I'm not sure about this yet, but it shouldn't be too terrible as long as there not that many instantiations of templates in the public headers (although that might actually be the case)

github-actions[bot] commented 2 years ago

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.