search

rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/
Apache License 2.0
29 stars 46 forks source link

Add behavior change notices to `NATIVE` #317

Open robertmaynard opened 1 year ago

robertmaynard commented 1 year ago

Is your feature request related to a problem? Please describe. We want to announce behavior changes coming of the NATIVE case of CMAKE_CUDA_ARCHITECTURES from rapids-cmake.

Describe the solution you'd like Unlike #316 the swtich from NATIVE to native does have an observable side-effect on the project. The rapids-cmake NATIVE resolves down to the actual architecture value ( 75-real ) after the project() call, while native stays native as now nvcc supports flags like -arch=native.

What we want to do for 22.03 is add a behavior notice to rapids-cmake that NATIVE will map to native starting in 23.04.

robertmaynard commented 1 year ago

The behavior change should also state that NATIVE will be removed in 23.06

robertmaynard commented 1 year ago

Also remember to incldue "" in the behavior change / deprecation notice

robertmaynard commented 4 months ago

Was thinking about this again and wanted to measure the performance cost of using -arch=native compared to what rapids-cmake does.

For libcudf total compile times at -j20 go from 8min 42sec to 8min 44sec so basically noise. We shouldn't consider performance of -arch=native to a issue when switching rapids-cmake NATIVE over to native.