Remove unneeded whitespace from json

rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/

Apache License 2.0

30 stars 46 forks source link

Remove unneeded whitespace from json #544

Closed robertmaynard closed 8 months ago

robertmaynard commented 8 months ago

Description

While the JSON spec allows whitespace before or after any structural character, some json linters complain about it. So we remove the 'offending' whitespace.

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] The documentation is up to date with these changes.

robertmaynard commented 8 months ago

What program did you use to find these? I think we'd do well to add it as a pre-commit hook.

Brought up as a style issue during https://github.com/rapidsai/rapids-cmake/pull/530 and I manually found this with grep.

@bdice Is looking at adding the pre-commit hook currently

bdice commented 8 months ago

@KyleFromNVIDIA I added a hook called pretty-format-json. It seems to do the job we want.

robertmaynard commented 8 months ago

/merge