Closed trxcllnt closed 7 months ago
fmt version 10.1.1 isn't reflected in core.h for tag 10.1.1, yielding a fmt CMake package with version 10.1.0.
fmt
This leads to find_package(fmt 10.1.1) failing if a user configures and installs fmt from the 10.1.1 tag.
find_package(fmt 10.1.1)
The fmt maintainer prefers not to hotfix tag 10.1.1, so we should patch it in rapids-cmake.
rapids-cmake
This PR adds a patch to update the version in core.h to 100101, i.e. v10.1.1.
core.h
100101
cmake-format.json
include_guard(GLOBAL)
/merge
Description
fmt
version 10.1.1 isn't reflected in core.h for tag 10.1.1, yielding afmt
CMake package with version 10.1.0.This leads to
find_package(fmt 10.1.1)
failing if a user configures and installsfmt
from the 10.1.1 tag.The
fmt
maintainer prefers not to hotfix tag 10.1.1, so we should patch it inrapids-cmake
.This PR adds a patch to update the version in
core.h
to100101
, i.e. v10.1.1.Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)