search

rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/
Apache License 2.0
27 stars 45 forks source link

[FEA] Allow providing a different default `versions.json` #587

Closed trxcllnt closed 4 months ago

trxcllnt commented 4 months ago

Is your feature request related to a problem? Please describe. Need the ability to specify the default versions.json file used by a build, rather than always using the one in rapids-cmake.

Describe the solution you'd like

Describe alternatives you've considered Right now we have to fork rapids-cmake, modify versions.json, and configure each project with custom -Drapids-cmake-repo= and -Drapids-cmake-branch= arguments.

Additional context This is necessary for doing CCCL upgrades, modifying versions of dependencies built in DLFW, etc.

robertmaynard commented 4 months ago

We should do this feature and https://github.com/rapidsai/rapids-cmake/issues/552 at the same time so we have symmetry

vyasr commented 4 months ago

Could you remind me why using an override json isn't sufficient here?

robertmaynard commented 4 months ago

Could you remind me why using an override json isn't sufficient here?

I think that for some cases, #552 would be sufficient. But override json files, and default json files do have different semantics when it comes to rapids_cpm_find, and CPMFindPackage hooks.

In the case of default json files they are only used when doing rapids_cpm_<pkg> while overrides take over all calls no matter the source ( rapids_cpm_find, rapids_cpm_<pkg>, CPMFindPackage, etc ).

So depending on desired behavior you might want a new default json so that you only override rapids_cpm_<pkg>.

robertmaynard commented 4 months ago

Closing as this feature is now complete with #596 being merged.