rapids_write_dependencies (should be rapids_export_write_dependencies)
rapids_write_language (should be rapids_export_write_language)
This fixes those, along with another formatting error causing one of them to not be rendered as inline code.
Notes for Reviewers
I'd expect to see typos like this caught by sphinx... but I don't see any warnings raised in the most recent docs build for this repo (build link). So I'm not sure how to easily prevent such things in CI in the future.
Maybe something like a CI job that does link-checking across RAPIDS would be able to catch things like this in the future. Linking the relevant issue tracking that idea: https://github.com/rapidsai/build-planning/issues/9
robertmaynard
commented
4 months ago
Description
Reading through https://docs.rapids.ai/api/rapids-cmake/stable/api/ today, I noticed two apparent typos
rapids_write_dependencies(should berapids_export_write_dependencies)rapids_write_language(should berapids_export_write_language)This fixes those, along with another formatting error causing one of them to not be rendered as inline code.
Notes for Reviewers
I'd expect to see typos like this caught by
sphinx... but I don't see any warnings raised in the most recent docs build for this repo (build link). So I'm not sure how to easily prevent such things in CI in the future.Maybe something like a CI job that does link-checking across RAPIDS would be able to catch things like this in the future. Linking the relevant issue tracking that idea: https://github.com/rapidsai/build-planning/issues/9
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))