Closed trxcllnt closed 4 months ago
I noticed we do this in RMM for spdlog, so maybe we should do that in rapids-cmake/cpm/spdlog.cmake
instead?
I noticed we do this in RMM for spdlog, so maybe we should do that in
rapids-cmake/cpm/spdlog.cmake
instead?
There is an open issue to track that refactoring. https://github.com/rapidsai/rapids-cmake/pull/592 started down that path as part of the update to a newer spdlog version.
@trxcllnt I updated the PR to consistently use the name nvtx3
instead of NVTX3
. Doing so makes the package logic consistent , and removes the need to do rapids_export_package(BUILD nvtx3 ${_RAPIDS_BUILD_EXPORT_SET} GLOBAL_TARGETS nvtx3-c nvtx3-cpp)
as that is now properly done by rapids_cpm_find
since it is given the corrected name.
Tested with a local rmm build tree and I see rmm the correct usage of the nvtx3 package in the rmm build tree.
/merge
Description
Fixes the following error:
Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)