rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/
Apache License 2.0
27 stars 44 forks source link

Always offer the install target names for nvtx3 #617

Closed robertmaynard closed 1 month ago

robertmaynard commented 1 month ago

Description

This is required so that consumers of nvtx3 can safely use nvtx3::nvtx3-cpp consistently no matter if they are using nvtx3 from source or an installed version.

Checklist

trxcllnt commented 1 month ago

@robertmaynard do we also want to add this to the FINAL_CODE_BLOCK of the rapids_export() calls? I recall we also needed to do this in get_arrow.cmake.

robertmaynard commented 1 month ago

@robertmaynard do we also want to add this to the FINAL_CODE_BLOCK of the rapids_export() calls? I recall we also needed to do this in get_arrow.cmake.

We won't need to do that with nvtx3 since rapids-cmake is generating the build and install nvtx3-config.cmake and nvtx3-targets.cmake.

robertmaynard commented 1 month ago

/merge