rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/
Apache License 2.0
29 stars 46 forks source link

Upgrade nvcomp to 4.0.1 #633

Closed vuule closed 1 month ago

vuule commented 3 months ago

Description

Upgrade to nvcomp 4.0. As part of that change we need to refactor the nvcomp.cmake to be aware of the new CMake files and targets that nvcomp generates.

Checklist

robertmaynard commented 2 months ago

URL form for nvcomp 4.0 has changed we need nvcomp-linux-sbsa-4.0.0-cuda12.5.tar.gz instead of nvcomp_4.0.0_SBSA_12.x.tgz

Likewise for x86 which is now nvcomp-linux-x86_64-4.0.0-cuda12.5.tar.gz

robertmaynard commented 2 months ago

Going to look at the changes required in rapids-cmake to support these new url strings later today

robertmaynard commented 2 months ago

More changes are required as the nvcomp 4.0 cmake package has a different set of files which needs to be patched for a proper install layout

robertmaynard commented 2 months ago

Waiting on https://github.com/rapidsai/cudf/pull/16076/files being ready to merge

robertmaynard commented 2 months ago

Blocked due to nvcomp now having a hard libcuda.so dependency.

bdice commented 1 month ago

/merge