Set CUDA_RUNTIME_LIBRARY to documented case style

rapidsai / rapids-cmake

Apache License 2.0

27 stars 44 forks source link

Closed KyleFromNVIDIA closed 1 week ago

KyleFromNVIDIA commented 1 week ago

CMake documentation lists "Shared" and "Static", not "SHARED" and "STATIC". Set the value with the documented casing.

[ ] I am familiar with the Contributing Guidelines.
[ ] New or existing tests cover these changes.
[ ] The documentation is up to date with these changes.
[ ] The cmake-format.json is up to date with these changes.
[ ] I have added new files under rapids-cmake/
- [ ] I have added include guards (include_guard(GLOBAL))
- [ ] I have added the associated docs/ rst file and update the api.rst

KyleFromNVIDIA commented 1 week ago

Indeed - I had not noticed that when reading the CMake code. Thanks.

KyleFromNVIDIA commented 1 week ago

Given that this PR doesn't really fix anything, I'm fine with just closing it and leaving things as they are.

robertmaynard commented 1 week ago

Given that this PR doesn't really fix anything, I'm fine with just closing it and leaving things as they are.

I think matching the documented public API for this function is a good call. We should towards the public API and not the internal implementation.

I would just like to revise the commit message and title to better reflect that. e.g. "Set CUDA_RUNTIME_LIBRARY to documented case style"

KyleFromNVIDIA commented 1 week ago

OK, I've updated the PR title and description.

KyleFromNVIDIA commented 1 week ago

/merge