search

rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/
Apache License 2.0
30 stars 46 forks source link

update fmt (to 11.0.2) and spdlog (to 1.14.1) #689

Closed jameslamb closed 2 months ago

jameslamb commented 2 months ago

Description

Contributes to https://github.com/rapidsai/build-planning/issues/56

Replaces https://github.com/rapidsai/rapids-cmake/pull/592

Now that most of conda-forge has been updated to fmt >=11.0.1,<12.0a0 and spdlog>=1.14.1,<1.15 (https://github.com/rapidsai/build-planning/issues/56#issuecomment-2334281452), we're attempting to upgrade RAPIDS to similar versions of those libraries... so that the next release of RAPIDS will be installable alongside newer versions of its dependencies and complementary packages on conda-forge.

Notes for Reviewers

This will also have the added side-benefit of (at least for now) shrinking the size and install time of some RAPIDS conda packages... because now builds will get spdlog from those conda-forge packages, instead of downloading it via CPM and then vendoring it.

How I tested this

Opened PRs in some other RAPIDS repos using rapids-cmake from here and rmm from https://github.com/rapidsai/rmm/pull/1678.

See the list at https://github.com/rapidsai/build-planning/issues/56

Also tested in unified devcontainers, with all RAPIDS repos at (in devcontainers manifest.yaml) checked out to the branches from those PRs (pointed at my fork of rapids-cmake here), like this:

uninstall-all -j
clean-all -j
build-all -j

./rmm/ci/run_pytests.sh
./cudf/ci/run_cudf_pytests.sh
./cuml/ci/run_cuml_singlegpu_pytests.sh

pushd ./cuspatial/python/cuspatial/cuspatial
python -m pytest \
  --cache-clear \
  --numprocesses=8 \
  --dist=worksteal \
  tests

Saw everything build successfully and all the tests pass (with CUDA 12.2, on x86_64).

Checklist