rapidsai / rapids-cmake

https://docs.rapids.ai/api/rapids-cmake/stable/
Apache License 2.0
30 stars 46 forks source link

Remove `fmt` 11.0.2 patch #695

Open jameslamb opened 2 months ago

jameslamb commented 2 months ago

Description

RAPIDS updated to fmt 11.0.2 in #689. To do that, rapids-cmake project took on a patch to suppress warnings from nvcc about a bit of code in fmt being unreachable.

references:

That patch should be removed and fixes upstreamed to the appropriate places (e.g. RAPIDS code, fmt, nvcc).

Benefits of this work

Acceptance Criteria

Approach

First, try to reproduce the error. That could probably be done like this (haven't re-tested as of this writing):

Try to narrow down:

Submit fixes that'd allow the fmt patch in rapids-cmake to be removed.

Notes

Would also help with these: