search

rapidsai / rapids.ai

rapids.ai web site
https://rapids.ai
8 stars 17 forks source link

Adding required Cookie Banner #391

Closed exactlyallan closed 1 month ago

exactlyallan commented 1 month ago

Per #387 request

bdice commented 1 month ago

@exactlyallan Can you rebase this? It shows five commits. Also your last commit appears as unverified…

exactlyallan commented 1 month ago

@bdice ...syncing my fork in the UI does not do what I think it does. Ill redo.

bdice commented 1 month ago

@exactlyallan I think part of the problem is that you need to create a branch on your fork, like exactlyallan:add-cookie-banner rather than pushing to your fork’s main branch and opening the PR from your fork’s main branch. You should never commit to your fork’s main. There is a contributing guide for cudf here with more details: https://github.com/rapidsai/cudf/blob/branch-24.10/CONTRIBUTING.md#your-first-issue